Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): adjust connector deletion #968

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat(connector): adjust connector deletion #968

merged 2 commits into from
Sep 10, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Sep 3, 2024

Description

  • add flag to define whether a linked service account should be deleted
  • adjust deletion logic for service accounts when deleting a connector

Why

The deletion logic for connectors currently doesn't support the deletion process of external service accounts

Issue

Refs: #966 #967

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Phil91 Phil91 changed the base branch from main to release/v2.2.0-RC4 September 3, 2024 12:32
@Phil91 Phil91 added this to the Release 2.2.0 milestone Sep 3, 2024
@Phil91 Phil91 added the priority PR needs to prioritized at review label Sep 6, 2024
@Phil91 Phil91 force-pushed the feature/966-delete-connector branch 4 times, most recently from a3ec89d to adb7ca9 Compare September 9, 2024 06:43
evegufy
evegufy requested changes Sep 9, 2024
View reviewed changes
...s/administration/Administration.Service.Tests/BusinessLogic/ServiceAccountManagementTests.cs Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file header missing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@Phil91
feat(connector): adjust connector deletion
66c05e4 
* add flag to define whether a linked service account should be deleted
* adjust deletion logic for service accounts when deleting a connector

Refs: #966 #967
@Phil91
chore: add file header
3722dfa 
Refs: #966
@Phil91 Phil91 requested a review from evegufy September 10, 2024 05:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Phil91 Phil91 merged commit c84034c into release/v2.2.0-RC4 Sep 10, 2024
11 checks passed
@Phil91 Phil91 deleted the feature/966-delete-connector branch September 10, 2024 09:19
@ntruchsess ntruchsess mentioned this pull request Sep 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evegufy evegufy evegufy approved these changes

@ntruchsess ntruchsess Awaiting requested review from ntruchsess

Assignees
No one assigned
Labels
priority PR needs to prioritized at review
Projects
Portal
Status: USER READY
Milestone
Release 2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Phil91 @evegufy