feat(technicaluser): new parameters for api expansion for technical user data added #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...dministration/Administration.Service.Tests/BusinessLogic/ServiceAccountBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
...dministration/Administration.Service.Tests/BusinessLogic/ServiceAccountBusinessLogicTests.cs
Fixed
Show fixed
Hide fixed
|
@AnuragNagpure please solve the codeQl findings |
Phil91
requested changes
Sep 16, 2024
src/administration/Administration.Service/BusinessLogic/ServiceAccountBusinessLogic.cs
Outdated
Show resolved
Hide resolved
AnuragNagpure
force-pushed
the
feature/976-api-expansion-for-technical-user-information
branch
from
60e5ae6
to
cfef334
Compare
Phil91
requested changes
Sep 18, 2024
src/administration/Administration.Service/BusinessLogic/ServiceAccountBusinessLogic.cs
Outdated
Show resolved
Hide resolved
src/administration/Administration.Service/Models/ServiceAccountConnectorOfferData.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Models/CompanyServiceAccountDetailedData.cs
Outdated
Show resolved
Hide resolved
src/portalbackend/PortalBackend.DBAccess/Repositories/ServiceAccountRepository.cs
Outdated
Show resolved
Hide resolved
...dministration/Administration.Service.Tests/BusinessLogic/ServiceAccountBusinessLogicTests.cs
Show resolved
Hide resolved
...dministration/Administration.Service.Tests/BusinessLogic/ServiceAccountBusinessLogicTests.cs
Outdated
Show resolved
Hide resolved
|
Phil91
approved these changes
Sep 19, 2024
|
Phil91
approved these changes
Sep 19, 2024
3 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Parameter usertype and authentication_service_url in below mentioned api
GET: api/administration/serviceaccount/owncompany/serviceaccounts/{GetServiceAccountId}
Why
For checking user_type internal or external and valid authenticatio_service_url for specific technical user
Issue
#976
Checklist
Please delete options that are not relevant.