Chore/cleanup itemstock2 #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../java/org/eclipse/tractusx/puris/backend/stock/controller/ItemStockRequestApiController.java
Dismissed
Show dismissed
Hide dismissed
Merged
2 tasks
tom-rm-meyer-ISST
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Thanks for cleaning up! :)
While walking through the changes I found two things we should rename during cleanup:
- properties for the submodel endpoint for item stock currently are just named generic reqeust api (see comment)
- we oversaw the method
buildItemStock2RegistrationBodyinEdcRequestBodyBuilderwhen renaming to itemStockSubmodel
backend/src/main/java/org/eclipse/tractusx/puris/backend/common/util/VariablesService.java
Show resolved
Hide resolved
tom-rm-meyer-ISST
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed unused methods in EdcAdapterService and EdcRequestBodyBuilder
removed unused enums
removed unused properties
please ignore this PR until this PR is merged
DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
Copyright and license header are present on all affected files