feat: Implemented days of supply - backend #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: implemented the backend for Days of Supply
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...main/java/org/eclipse/tractusx/puris/backend/supply/logic/service/SupplierSupplyService.java
Fixed
Show resolved
Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/supply/logic/service/CustomerSupplyService.java
Fixed
Show resolved
Hide resolved
tom-rm-meyer-ISST
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Thanks for contributing. While reviewing I noticed the duplicate code we currently have in most of the object. I would prefer a refactoring prior to this PR so that we don't have that much duplication e.g., in methods like findAllByFilters. Same applies to new functionality to calculate days of supply which is the same calculation with different parameters.
Beside that:
- Please always wait for the pipeline to finish prior to requesting the review and check the findings. If you're not aware of what to do, please comment.
- Please add javadoc at least for the more complex functions. Normally also at least those should be tested.
.../main/java/org/eclipse/tractusx/puris/backend/delivery/logic/service/OwnDeliveryService.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/tractusx/puris/backend/delivery/logic/service/OwnDeliveryService.java
Outdated
Show resolved
Hide resolved
.../java/org/eclipse/tractusx/puris/backend/delivery/logic/service/ReportedDeliveryService.java
Outdated
Show resolved
Hide resolved
...nd/src/main/java/org/eclipse/tractusx/puris/backend/demand/logic/services/DemandService.java
Show resolved
Hide resolved
...n/java/org/eclipse/tractusx/puris/backend/production/logic/service/OwnProductionService.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/supply/logic/service/CustomerSupplyService.java
Show resolved
Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/supply/logic/service/CustomerSupplyService.java
Outdated
Show resolved
Hide resolved
...main/java/org/eclipse/tractusx/puris/backend/supply/logic/service/SupplierSupplyService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/org/eclipse/tractusx/puris/backend/common/security/SecurityConfig.java
Outdated
Show resolved
Hide resolved
...clipse/tractusx/puris/backend/supply/domain/repository/ReportedSupplierSupplyRepository.java
Show resolved
Hide resolved
tom-rm-meyer-ISST
requested changes
Jun 12, 2024
...main/java/org/eclipse/tractusx/puris/backend/supply/logic/service/SupplierSupplyService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks for contributing and iterating over this with me! Highly appreciated. As we have more than 1kloc of code change, I filed an IP check at EF.
I will approve and merge as soon as the check succeeded.
Beside that: raised #454 to increase maintainability
|
IP check succeeded. Please merge main |
tom-rm-meyer-ISST
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: