Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base64 encoding #512

Merged

Conversation

eschrewe
Copy link
Contributor

Description

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

  • DEPENDENCIES are up-to-date. Dash license tool. Committers can open IP issues for restricted libs.
  • Copyright and license header are present on all affected files
  • If helm chart has been changed, the chart version has been bumped to either next major, minor or patch level (compared to released chart).

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. Beside the one comment, please also check on the following:

  • Tests are failing for MaterialPartnerRelationsControllerTest and MaterialControllerTest.getMaterialTest()
  • Controller for Days of supply also has unencoded material numbers
  • Postman collection needs an update to use scripted value
  • opening stock view throws an error (StockViewController.getCustomerProductStocks(StockViewController.java:476)

frontend/src/features/dashboard/components/Dashboard.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Beside one test in the postman colleciton failing, opening Stock View, selecting tab Products leads to an error:

customer-backend        | java.lang.IllegalArgumentException: Last unit does not have enough valid bits
customer-backend        |       at java.base/java.util.Base64$Decoder.decode0(Unknown Source) ~[na:na]
customer-backend        |       at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[na:na]
customer-backend        |       at java.base/java.util.Base64$Decoder.decode(Unknown Source) ~[na:na]
customer-backend        |       at org.eclipse.tractusx.puris.backend.stock.controller.StockViewController.getSupplierMaterialStocks(StockViewController.java:438) ~[!/:2.0.2]
customer-backend        |       at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source) ~[na:na]
customer-backend        |       at java.base/java.lang.reflect.Method.invoke(Unknown Source) ~[na:na]

Please check

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postman collection works fine! Please check for the exception thrown when opening the stock view.

Copy link
Contributor

@tom-rm-meyer-ISST tom-rm-meyer-ISST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pushed small coalescing change. Thanks for your work!

@tom-rm-meyer-ISST tom-rm-meyer-ISST merged commit 7a8fe6d into eclipse-tractusx:main Aug 8, 2024
12 checks passed
@tom-rm-meyer-ISST tom-rm-meyer-ISST deleted the fix/base64encoding branch August 8, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential problem with ownMaterialNumbers in request params of endpoints
2 participants