(feat): reuseable workflows for static puml / mermaid files #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FaGru3n
requested review from
SebastianBezold,
tomaszbarwicki,
carslen,
almadigabor,
Siegfriedk and
hzierer
SebastianBezold
suggested changes
Jul 10, 2023
| do | ||
| mmdc -i $file -o ${file%.*}.svg | ||
| echo "${file%.*}.svg" | ||
| git add ${file%.*}.svg |
There was a problem hiding this comment.
I am unsure, what this is doing. git add, without commit? Is this needed, it there is an git-auto-commit-action
In general I still think, that it is not a good idea to autocommit things that where generated from a PR.
The minimal change, that I would want to see here, is an environment variable that controls, whether or not the auto-commit is done. It should default to false
There was a problem hiding this comment.
at this step it will only staged, in case of there are more files that have changes.
At the current point this workflow just keep the static files updated.
There was a problem hiding this comment.
---
title: workflow currently works
---
flowchart TD
A[Reason: I want to change puml / mmd ] --> B(create PR)
B --> C(someone approve pr on codelines)
C --> D(merge pr)
D --> E(Workflow checks that there are changed puml/mmd codefiles)
E --> F(workflow provides new static files )
F --> G(update static files on main)
…167) - add example workflows to check dependencies for yarn and dotnet the workflows also provide a quite easy option to update the DEPENDENCIES file (without committing on the feature branch via bot or opening another PR, I didn't like both options): once all the previous step were successful so that no restricted dependencies are in the DEPENDENCIES file anymore, the last step uploads the updated DEPENDENCIES file to the workflow as downloadable artifact which can then be easily committed.
feat: add `run-dash` action to analyze 3rd party dependencies
…es as job artifact
+ adapt README.md references
…es as job artifact
…files' into feat/reuseable_workflows_static_files # Conflicts: # README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.svg-files from found mermaid files.svg-files from found plantuml filesReadMe.mdquality check.github/workflows/reusable-generate-mermaid-svg.yaml
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review:
FaGru3n, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum