Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuer Approval/Rejection process #13

Closed
Tracked by #2 ...
jjeroch opened this issue Mar 6, 2024 · 0 comments
Closed
Tracked by #2 ...

Issuer Approval/Rejection process #13

jjeroch opened this issue Mar 6, 2024 · 0 comments
Assignees
Labels
Sub-task A small piece of work that's part of a larger task.

Comments

@jjeroch
Copy link
Contributor

jjeroch commented Mar 6, 2024

Ticket under creation

Current available endpoints

  • /api/administration/companydata/credentials/{credentialId}/approval
  • /api/administration/companydata/credentials/{credentialId}/reject

are to be moved to the Issuer component. Interim: instead of moving; duplicate them.
Authorization: only the Issuer is allowed to run those endpoints

- 204 - Successfully rejected the credential.
- 401 - The User is unauthorized
- 404 - Credential does not exists
- 409 - Credential in Incorrect State
- 500 - Internal Server Error

Short Process Summary:
Portal schickt Anfrage "leg bitte ein BPN Credential an" -> IssuerComponent speichert und validiert die Daten.
Operator gibt Approval für das Credential und der Process wird gestartet -> Credential wird angelegt -> signiert und wenn gewollt ins Holder Wallet geschrieben.

NOTE - the approval process is only relevant for specific credentials.
In the current state that covers the following credentials:

  • FrameWork
  • Dismantler

Any other current existing credential types do not need a separate approval

@jjeroch jjeroch added the Sub-task A small piece of work that's part of a larger task. label Mar 6, 2024
@jjeroch jjeroch added this to the CX Release 24.05 (dev) milestone Mar 6, 2024
@Phil91 Phil91 mentioned this issue Mar 8, 2024
9 tasks
Phil91 added a commit that referenced this issue Mar 25, 2024
* feat: add issuer component
* build: add helm chart for issuer component
* feat(notification): adjust notification endpoint
* fix(build): enable build of docker images (#21)
* feat: add callback process step
* chore: enable helm chart (#22)
* fix: remove lint issue
* fix: solve templating issues
* chore: change setup of cronjobs: remove hooks
* chore: change name setup of job resources
* chore: add line breaks
* chore: move placeholder value into resources
* chore: change to unique templates for db subchart
* chore: change secret setup
* chore: move passwords from db dependency to according section
* chore: remove upgrade env file
* chore: change centralidp setup
* chore: rearrange health checks
* chore: rearrange values file
* chore: change ingress to trg-5.04
* chore: fix container name and namespace
* chore: change image tag retrieval
* chore: change version
* chore(db-dependency): change image tag to get latest minor updates
* chore: set resource limits
* chore: update readme files
* chore: change credentialexpiry to camelcase
* chore: fix helm chart, improve workflows and docs (#23)
* chore(helm-test): fix image name and tag override at upgrade
* chore: fix owasp scan
* chore(helm-test and owasp): change set command
* chore: re-arrange values file
* chore(pre-checks): run only on changes to src/**
* docs(CONTRIBUTING.md): update to contribution details
* chore: fix db dependency secret name in cronjobs
* chore(dependencies-check): align file naming and docs
* chore: remove white space

---------

Refs: #2 #3 #4 #5 #6 #7 #8 #9 #13 #21 #22 #23
Reviewed-by: Evelyn Gurschler <evelyn.gurschler@bmw.de>
Reviewed-by: Norbert Truchsess <norbert.truchsess@t-online.de>
Co-authored-by: Evelyn Gurschler <evelyn.gurschler@bmw.de>
Co-authored-by: Norbert Truchsess <norbert.truchsess@t-online.de>
Phil91 added a commit that referenced this issue Apr 8, 2024
* feat: add issuer component
* build: add helm chart for issuer component
* feat(notification): adjust notification endpoint
* fix(build): enable build of docker images (#21)
* feat: add callback process step
* chore: enable helm chart (#22)
* fix: remove lint issue
* fix: solve templating issues
* chore: change setup of cronjobs: remove hooks
* chore: change name setup of job resources
* chore: add line breaks
* chore: move placeholder value into resources
* chore: change to unique templates for db subchart
* chore: change secret setup
* chore: move passwords from db dependency to according section
* chore: remove upgrade env file
* chore: change centralidp setup
* chore: rearrange health checks
* chore: rearrange values file
* chore: change ingress to trg-5.04
* chore: fix container name and namespace
* chore: change image tag retrieval
* chore: change version
* chore(db-dependency): change image tag to get latest minor updates
* chore: set resource limits
* chore: update readme files
* chore: change credentialexpiry to camelcase
* chore: fix helm chart, improve workflows and docs (#23)
* chore(helm-test): fix image name and tag override at upgrade
* chore: fix owasp scan
* chore(helm-test and owasp): change set command
* chore: re-arrange values file
* chore(pre-checks): run only on changes to src/**
* docs(CONTRIBUTING.md): update to contribution details
* chore: fix db dependency secret name in cronjobs
* chore(dependencies-check): align file naming and docs
* chore: remove white space

---------

Refs: #2 #3 #4 #5 #6 #7 #8 #9 #13 #21 #22 #23
Reviewed-by: Evelyn Gurschler <evelyn.gurschler@bmw.de>
Reviewed-by: Norbert Truchsess <norbert.truchsess@t-online.de>
Co-authored-by: Evelyn Gurschler <evelyn.gurschler@bmw.de>
Co-authored-by: Norbert Truchsess <norbert.truchsess@t-online.de>
@msinamci msinamci closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sub-task A small piece of work that's part of a larger task.
Projects
Archived in project
Development

No branches or pull requests

3 participants