Skip to content

Commit

Permalink
Merge pull request #1238 from mkanal/chore/#1070-release-checks-R24.8…
Browse files Browse the repository at this point in the history
…_Part2

Chore/#1070 release checks r24.8 part2 - #1070 Convert png to svg according to TRG 1.04 - Diagrams as code / Editable static files
  • Loading branch information
ds-mwesener authored Jul 19, 2024
2 parents 2760b68 + 588ca6b commit 11ff33b
Show file tree
Hide file tree
Showing 41 changed files with 838 additions and 22 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ _**For better traceability add the corresponding GitHub issue number in each cha
- #1190 update notification contracts on policy updates

### Changed
- #1070 Convert png to svg according to TRG 1.04 - Diagrams as code / Editable static files
- #1173 Update IRS-Helm from 7.1.4 to 7.2.0 - updated Compatibility Matrix
- #1082 fix duplicate key errors when synchronizing assets with IRS
- #970 fixed bug where the right operand of policies was not showing up in table and detailed view
Expand Down
13 changes: 6 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,21 +122,20 @@ The commit messages have to match a pattern in the form of:
````

````
fix(api):[TRACEFOSS-123] Fix summary what is fixed.
chore(repos):[TRACEFOSS-123] Configuration change of ci cd pipeline for new repository.
docs(arc42):[TRACEFOSS-123] Added level 1 description for runtime view.
chore(helm): TRACEFOSS-1131- Moving the values under the global key - increasing the version
fix(api):[#123] Fix summary what is fixed.
chore(repos):[#123] Configuration change of ci cd pipeline for new repository.
docs(arc42):[#123] Added level 1 description for runtime view.
chore(helm):[#113] Moving the values under the global key - increasing the version
````

## Pull Request &  Reviews

The goal is that the maximal life cycle of a pull request: 1.5 days.
The goal is that the maximal life cycle of a pull request: 1.5 days.

**Steps:**

- Every developer creating a pull request is responsible to assign a reviewer.
- Add comment for pull request with required information. 
- Add comment for pull request with required information.
- Please check the availability of a reviewer. The daily might be a good way to check the availability of team members.
- If Review needs to be planned: Assign corresponding Jira ticket to reviewer, with link to pull-request

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ The standard notification status flow must **not** be changed. The "FAILED" stat
After the notification is successfully resent, the status will be set to "SENT". Alternatively, the user can cancel the notification flow, which will set the status to "CANCELLED"/"CLOSED".

Notification status flow:
![Notification-Status-Flow.png](Notification-Status-Flow.png)
![Notification-Status-Flow](Notification-Status-Flow.svg)

Creating and sending notifications:
```mermaid
Expand Down Expand Up @@ -102,9 +102,9 @@ After creating and approving the notification and one of the exceptions is throw
3. A new message must be created and shown in the message history including the error description

UsagePolicyPermissionException:
![UsagePolicyPermissionException-Mockup.png](UsagePolicyPermissionException-Mockup.png)
![UsagePolicyPermissionException-Mockup](UsagePolicyPermissionException-Mockup.svg)
UsagePolicyExpiredException:
![UsagePolicyExpiredException-Mockup.png](UsagePolicyExpiredException-Mockup.png)
![UsagePolicyExpiredException-Mockup](UsagePolicyExpiredException-Mockup.svg)

# References

Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
# Overview
In the frontend there are multiple versions of 'empty' values:

![example-values-frontend.png](example-values-frontend.png)
![example-values-frontend](example-values-frontend.svg)

In the backend those values are as follows:

![example-values-backend.png](example-values-backend.png)
![example-values-backend](example-values-backend.svg)

These should be consistent throughout Trace-X.

Expand All @@ -49,19 +49,19 @@ Whenever a string is saved or updated in the database and during data consumptio
### Frontend
Null values should be shown in the frontend as a dash:

![null-value-display.png](null-value-display.png)
![null-value-display](null-value-display.svg)

When sorting the values, null must be treated the default way of the database. When sorted ascending, they are at the end. When sorted descending, they are at the beginning.
Filtering for empty values must be possible. In the filter box "-" should always be shown at the top regardless of what the user is searching for.

![null-value-filter.png](null-value-filter.png)
![null-value-filter](null-value-filter.svg)

In order to reduce the amount of whitespace characters in the database, leading and trailing whitespaces should not be counted during user input.

![null-value-input-leading-and-trailing.png](null-value-input-leading-and-trailing.png)
![null-value-input-leading-and-trailing](null-value-input-leading-and-trailing.svg)
In this example, the amount of counted characters should be 10 ("blank" + " " + "test") instead of 43.

![null-value-input-only-spaces.png](null-value-input-only-spaces.png)
![null-value-input-only-spaces](null-value-input-only-spaces.svg)
Here, no characters should be counted and the input should not be accepted.

# References
Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
48 changes: 48 additions & 0 deletions docs/concept/#578-consistent-null-values/null-value-display.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
48 changes: 48 additions & 0 deletions docs/concept/#578-consistent-null-values/null-value-filter.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ BPNL0A will have those 3 messages and additionally the message sent to BPN2Y, wh
In the notification detail view, the message history will be changed according to the frontend concept:

**Creator/Sender:**
![frontend-notification-detail-view-sender.png](frontend-notification-detail-view-sender.png)
![frontend-notification-detail-view-sender](frontend-notification-detail-view-sender.svg)

The overview must be adapted to the backend changes.

Expand All @@ -373,15 +373,15 @@ Additionally, the user is able to edit the notification, send it or close it. (D
Clicking "send" will send messages to all BPNLs, where the last state was "CREATED" all messages that are in the state "CREATED". Other

**Recipient:**
![frontend-notification-detail-view-recipient.png](frontend-notification-detail-view-recipient.png)
![frontend-notification-detail-view-recipient](frontend-notification-detail-view-recipient.svg)

For the recipient not much changes, since a notification can only be received by a single BPNL. The overview and the message history should be aligned with the view from the sender.
The actions remain the same.

#### Create/Edit notifications
When creating or editing notifications, the user must be able to add/remove multiple BPNLs.
This should be made possible by having an autocomplete in the input text field. And showing selected BPNLs as removable chips:
![frontend-create-notification.png](frontend-create-notification.png)
![frontend-create-notification](frontend-create-notification.svg)
(-> identical for Edit Notification)

# References
Expand Down
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,11 @@ There is no possibility to create a new notification from the "Edit notification
If the user wants to send an existing notification to a different BPN, he must copy the data and use the "Create notification" process.

## Frontend
![multiple-bpns-modals.png](multiple-bpns-modals.png)
![notification-creation-bpn-selection.png](notification-creation-bpn-selection.png)
![multiple-bpns-modals](multiple-bpns-modals.svg)
![notification-creation-bpn-selection](notification-creation-bpn-selection.svg)

New case label:
![case-label.png](case-label.png)
![case-label](case-label.svg)

See https://miro.com/app/board/uXjVO5JVoho=/?moveToWidget=3458764586657591852&cot=10

Expand Down
Binary file not shown.
48 changes: 48 additions & 0 deletions docs/concept/#849-notifications-to-multiple-bpns/case-label.svg

Large diffs are not rendered by default.

Diff not rendered.

Large diffs are not rendered by default.

Diff not rendered.

Large diffs are not rendered by default.

Binary file removed docs/images/data_flow.png
Diff not rendered.
48 changes: 48 additions & 0 deletions docs/images/data_flow.svg

Large diffs are not rendered by default.

Binary file removed docs/images/modular_design.png
Diff not rendered.
48 changes: 48 additions & 0 deletions docs/images/modular_design.svg

Large diffs are not rendered by default.

0 comments on commit 11ff33b

Please sign in to comment.