Skip to content

Commit

Permalink
chore(irs):1105 Refactored.
Browse files Browse the repository at this point in the history
  • Loading branch information
ds-mwesener committed Jul 17, 2024
1 parent 33e07f6 commit 47efd8d
Show file tree
Hide file tree
Showing 5 changed files with 25 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
********************************************************************************/
package org.eclipse.tractusx.traceability.contracts.infrastructure.repository;

import lombok.experimental.SuperBuilder;
import com.fasterxml.jackson.databind.ObjectMapper;
import lombok.extern.slf4j.Slf4j;
import org.eclipse.tractusx.irs.edc.client.contract.model.exception.ContractAgreementException;
import org.eclipse.tractusx.irs.edc.client.contract.service.EdcContractAgreementService;
Expand All @@ -33,13 +33,16 @@
import java.util.stream.Collectors;

@Component
@SuperBuilder
@Slf4j
public class ContractAsBuiltRepositoryImpl extends ContractRepositoryImplBase implements ContractRepository<ContractAgreementAsBuiltEntity> {

private final EdcContractAgreementService edcContractAgreementService;
private final JpaContractAgreementAsBuiltRepository contractAgreementRepository;

public ContractAsBuiltRepositoryImpl(EdcContractAgreementService edcContractAgreementService, ObjectMapper objectMapper, JpaContractAgreementAsBuiltRepository contractAgreementRepository) {
super(edcContractAgreementService, objectMapper);
this.contractAgreementRepository = contractAgreementRepository;
}

@Override
public void saveAllContractAgreements(List<String> contractAgreementIds, ContractType contractType) throws ContractAgreementException {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
********************************************************************************/
package org.eclipse.tractusx.traceability.contracts.infrastructure.repository;

import lombok.experimental.SuperBuilder;
import com.fasterxml.jackson.databind.ObjectMapper;
import lombok.extern.slf4j.Slf4j;
import org.eclipse.tractusx.irs.edc.client.contract.model.exception.ContractAgreementException;
import org.eclipse.tractusx.irs.edc.client.contract.service.EdcContractAgreementService;
Expand All @@ -33,13 +33,16 @@
import java.util.stream.Collectors;

@Component
@SuperBuilder
@Slf4j
public class ContractAsPlannedRepositoryImpl extends ContractRepositoryImplBase implements ContractRepository<ContractAgreementAsPlannedEntity> {

private final EdcContractAgreementService edcContractAgreementService;
private final JpaContractAgreementAsPlannedRepository contractAgreementRepository;

public ContractAsPlannedRepositoryImpl(EdcContractAgreementService edcContractAgreementService, ObjectMapper objectMapper, JpaContractAgreementAsPlannedRepository contractAgreementRepository) {
super(edcContractAgreementService, objectMapper);
this.contractAgreementRepository = contractAgreementRepository;
}

@Override
public void saveAllContractAgreements(List<String> contractAgreementIds, ContractType contractType) throws ContractAgreementException {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
********************************************************************************/
package org.eclipse.tractusx.traceability.contracts.infrastructure.repository;

import com.fasterxml.jackson.databind.ObjectMapper;
import lombok.experimental.SuperBuilder;
import lombok.extern.slf4j.Slf4j;
import org.eclipse.tractusx.irs.edc.client.contract.model.exception.ContractAgreementException;
Expand All @@ -33,13 +34,16 @@
import java.util.stream.Collectors;

@Component
@SuperBuilder
@Slf4j
public class ContractNotificationRepositoryImpl extends ContractRepositoryImplBase implements ContractRepository<ContractAgreementNotificationEntity> {

private final EdcContractAgreementService edcContractAgreementService;
private final JpaContractAgreementNotificationRepository contractAgreementRepository;

public ContractNotificationRepositoryImpl(EdcContractAgreementService edcContractAgreementService, ObjectMapper objectMapper, EdcContractAgreementService edcContractAgreementService1, JpaContractAgreementNotificationRepository contractAgreementRepository) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'edcContractAgreementService1' is never used.
super(edcContractAgreementService, objectMapper);
this.contractAgreementRepository = contractAgreementRepository;
}

@Override
public void saveAllContractAgreements(List<String> contractAgreementIds, ContractType contractType) throws ContractAgreementException {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import lombok.AllArgsConstructor;
import lombok.RequiredArgsConstructor;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang3.tuple.ImmutablePair;
Expand All @@ -43,7 +44,7 @@
import java.util.stream.Collectors;

@Component
@RequiredArgsConstructor
@AllArgsConstructor
@Slf4j
public class ContractRepositoryImplBase {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
package org.eclipse.tractusx.traceability.contracts.infrastructure.repository;

import com.fasterxml.jackson.databind.ObjectMapper;
import lombok.experimental.SuperBuilder;
import lombok.extern.slf4j.Slf4j;
import org.eclipse.tractusx.irs.edc.client.contract.model.exception.ContractAgreementException;
import org.eclipse.tractusx.irs.edc.client.contract.service.EdcContractAgreementService;
Expand All @@ -41,13 +40,15 @@
import static org.apache.commons.collections4.ListUtils.emptyIfNull;

@Component
@SuperBuilder
@Slf4j
public class ContractViewRepositoryImpl extends ContractRepositoryImplBase implements ContractRepositoryReadOnly<ContractAgreementViewEntity> {

private final EdcContractAgreementService edcContractAgreementService;
private final JpaContractAgreementViewRepository contractAgreementRepository;
private final ObjectMapper objectMapper;

public ContractViewRepositoryImpl(EdcContractAgreementService edcContractAgreementService, ObjectMapper objectMapper, EdcContractAgreementService edcContractAgreementService1, JpaContractAgreementViewRepository contractAgreementRepository, ObjectMapper objectMapper1) {

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'edcContractAgreementService1' is never used.

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'objectMapper1' is never used.
super(edcContractAgreementService, objectMapper);
this.contractAgreementRepository = contractAgreementRepository;
}

@Override
public PageResult<Contract> getContractsByPageable(Pageable pageable, SearchCriteria searchCriteria) {
Expand Down

0 comments on commit 47efd8d

Please sign in to comment.