Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Rework of Post-Sync Extraction and Database Storage of contractAgreementIds #1105

Closed
5 tasks done
ds-mwesener opened this issue Jun 24, 2024 · 6 comments · Fixed by #1191, #1211 or #1264
Closed
5 tasks done
Assignees
Labels
3 - Data Souvereignty & Data Ingest backend Backend related issues bug Something isn't working frontend Frontend related Issues spillover temporary label for spill over

Comments

@ds-mwesener
Copy link
Contributor

ds-mwesener commented Jun 24, 2024

As a developer,
I want to extract and save contractAgreementIds for data consumption into the database after each data sync via IRS,
so that the data remains up-to-date and accurate without needing to restart the application.

Hints / Details

  • Currently, contractAgreementIds are only loaded during application startup.
  • The extraction and saving process should occur after each data synchronization via IRS.
  • Ensure that the database is updated correctly with the new contractAgreementIds.
  • Consider potential performance impacts and handle any possible errors during the extraction and saving process.

Acceptance Criteria

Backend

  • The application no longer relies on startup to load contractAgreementIds.
  • After each data sync via IRS, the contractAgreementIds are extracted and saved into the database.
  • The database reflects the most current contractAgreementIds without requiring a restart.
  • Appropriate error handling is implemented for the extraction and saving process.

Frontend

  • Execution of action "View parts" will also work if a part already has a new contractAgreementId since it was updated.

Out of Scope

  • Changes to the IRS data sync process itself.
  • Modifications to the application startup process other than removing the contractAgreementIds loading.
  • Any user interface updates related to contractAgreementIds.
@mkanal mkanal added the bug Something isn't working label Jun 26, 2024
@mkanal mkanal changed the title Implement Post-Sync Extraction and Database Storage of contractAgreementIds Rework Post-Sync Extraction and Database Storage of contractAgreementIds Jun 26, 2024
@mkanal mkanal changed the title Rework Post-Sync Extraction and Database Storage of contractAgreementIds Rework of Post-Sync Extraction and Database Storage of contractAgreementIds Jun 26, 2024
@mkanal mkanal added backend Backend related issues frontend Frontend related Issues labels Jun 26, 2024
@mkanal mkanal changed the title Rework of Post-Sync Extraction and Database Storage of contractAgreementIds [BUG] Rework of Post-Sync Extraction and Database Storage of contractAgreementIds Jun 26, 2024
@ds-mwesener ds-mwesener self-assigned this Jul 11, 2024
@ds-mmaul ds-mmaul self-assigned this Jul 12, 2024
@ds-mmaul ds-mmaul removed their assignment Jul 15, 2024
@ds-mmaul
Copy link
Contributor

ds-mmaul commented Jul 15, 2024

Hi @ds-mwesener, I adjusted the frontend to navigate to id in globalAssetId field with chore/#1105-fe-adjust-contract-asset-reference

ds-mmaul added a commit that referenced this issue Jul 16, 2024
…contract-asset-reference

chore(contracts): 1105 adjust part reference in contracts
@ds-crehm
Copy link
Contributor

Tested on E2E-A:
Contracts are updated after parts sync.
Links from contracts to notification work.

But the links to some of the parts do not work. Newly created contracts link to their parts without issue, but older contracts don't link to parts that have been resynced anymore. A frontend error happens without any indication to the user:
grafik

Please take another look. Thanks!

@ds-crehm ds-crehm reopened this Jul 19, 2024
@ds-crehm ds-crehm removed their assignment Jul 19, 2024
@ds-mwesener
Copy link
Contributor Author

Please validate again.

@mkanal mkanal added the spillover temporary label for spill over label Jul 23, 2024
@ds-mwesener
Copy link
Contributor Author

Has been reworked and tested. Please check (can be done on association environment)

@ds-crehm
Copy link
Contributor

Tested on INT: Links from contracts to the respective parts work now. Links from contracts to quality notifications work too.
Both contract types are shown and can be filtered as expected.
Ready for review.

@ds-crehm ds-crehm reopened this Jul 25, 2024
@ds-crehm ds-crehm assigned mkanal and unassigned ds-mwesener and ds-crehm Jul 25, 2024
@mkanal
Copy link
Contributor

mkanal commented Jul 25, 2024

LGFM. PO acceptance in behalf of @jzbmw .

@mkanal mkanal closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment