Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging the cause of random PGP failures #3382

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

laeubi
Copy link
Member

@laeubi laeubi commented Jan 18, 2024

FYI @merks

Copy link

github-actions bot commented Jan 18, 2024

Test Results

  579 files  ±0    579 suites  ±0   4h 7m 28s ⏱️ + 20m 50s
  392 tests ±0    384 ✅  - 1   7 💤 ±0  1 ❌ +1 
1 176 runs  ±0  1 151 ✅  - 3  22 💤 ±0  3 ❌ +3 

For more details on these failures, see this check.

Results for commit c76b4cd. ± Comparison against base commit e3e1b60.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Jan 18, 2024

It failed. Yeah!

@laeubi
Copy link
Member Author

laeubi commented Jan 18, 2024

The log says:

INFO] Trying to get the private key of the secret key of public key: ae85fc855206fc089735b2daf449ee9525282a89
[INFO] Got the private key of the secret key of public key: ae85fc855206fc089735b2daf449ee9525282a89
[DEBUG] [2265462a-cad2-496c-a82e-9c0249eaf205][extension>org.eclipse.tycho:tycho-maven-plugin:5.0.0-SNAPSHOT] Searching bundle for class interface org.eclipse.equinox.p2.core.IProvisioningAgent and location file:/C:/Users/runneradmin/.m2/repository/org/eclipse/platform/org.eclipse.equinox.p2.core/2.10.200/org.eclipse.equinox.p2.core-2.10.200.jar
[DEBUG] [2265462a-cad2-496c-a82e-9c0249eaf205][extension>org.eclipse.tycho:tycho-maven-plugin:5.0.0-SNAPSHOT] Return bundle org.eclipse.equinox.p2.core for location file:/C:/Users/runneradmin/.m2/repository/org/eclipse/platform/org.eclipse.equinox.p2.core/2.10.200/org.eclipse.equinox.p2.core-2.10.200.jar
[DEBUG] Enter loading repository file:/D:/a/tycho/tycho/tycho-its/target/projects/TestPGPSigning/testSigningSkipIfJarSignedAndAnchored/gpg.sign.p2.basic/site/target/repository
[DEBUG] Exit loading repository file:/D:/a/tycho/tycho/tycho-its/target/projects/TestPGPSigning/testSigningSkipIfJarSignedAndAnchored/gpg.sign.p2.basic/site/target/repository
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\plugins\org.eclipse.equinox.common_3.16.200.v20220817-1601.jar is already signed and signed jars should be skipped if anchored!
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\plugins\org.eclipse.osgi.source_3.18.100.v20220817-1601.jar is already signed and signed jars should be skipped if anchored!
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\plugins\org.eclipse.osgi_3.18.100.v20220817-1601.jar is already signed and signed jars should be skipped if anchored!
[DEBUG] D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\binary\org.eclipse.platform_root_4.25.0.v20220831-1800 is a binary and these should be skipped!
[DEBUG] Expanding: D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository\artifacts.jar into D:\a\tycho\tycho\tycho-its\target\projects\TestPGPSigning\testSigningSkipIfJarSignedAndAnchored\gpg.sign.p2.basic\site\target\repository
[DEBUG] expand complete

Does this help in any way?

@laeubi
Copy link
Member Author

laeubi commented Jan 24, 2024

It failed. Yeah!

I now tried to adjust the failing method in the following way:

  1. Check that all unsigned IUs are actually jar signed
  2. Check that all singed IUs are actually NOT jar signed
  3. Check that only one item is neither included in (1) or (2) ( == the root file)

I think this should replicate what the test wanted to assert @merks @mickaelistria but without using hard coded set of IU names?

@merks
Copy link
Contributor

merks commented Jan 24, 2024

Keep in mind jar-signed but not anchored case. I’m away from the computer so can’t look in detail.

@laeubi
Copy link
Member Author

laeubi commented Jan 24, 2024

I now successfully broke all PGP test (while the test locally succeeds) so it seems more that calling the check for signature itself seem to influence later checks ....

@laeubi
Copy link
Member Author

laeubi commented Jan 24, 2024

I now successfully broke all PGP test (while the test locally succeeds) so it seems more that calling the check for signature itself seem to influence later checks ....

Because some has hard coded checks to the org.eclipse.platform_root ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants