PR for changes to SocketUTransport to make it compatible with 1.5.8 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debruce
force-pushed
the
feature/socketUtransport
branch
2 times, most recently
from
6fc7268
to
04459c0
Compare
debruce
changed the title
gregmedd
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Looks good to me
I really don't have any complaints. The socket code all looks correct, locking is where it needs to be, the metaprogramming for the tuple hash looks right. There are a few small cleanup items, but none of them are really a dealbreaker.
I see no reason this could not be merged.
|
One more minor comment: you could squash the commits now that you know it builds. |
debruce
force-pushed
the
feature/socketUtransport
branch
from
58afd8d
to
c3a24ff
Compare
gregmedd
approved these changes
Jul 19, 2024
agosh01
reviewed
Jul 23, 2024
agosh01
reviewed
Jul 26, 2024
debruce
force-pushed
the
feature/socketUtransport
branch
5 times, most recently
from
067b713
to
04e6a7f
Compare
agosh01
reviewed
Jul 29, 2024
debruce
force-pushed
the
feature/socketUtransport
branch
5 times, most recently
from
f99f0aa
to
00b4399
Compare
gregmedd
approved these changes
Jul 30, 2024
gregmedd
reviewed
Jul 30, 2024
This PR implements a socket transport to the python dispacther script, and necessary data structures for listener callbacks and callback removal. The high level code is a private implementation in SocketUTransport.cpp. The unordered_map supporting callbacks is in SafeTupleMap.h. The details of this is std::hash extensions to hash tuples of optionals for filtering with wildcards.
debruce
force-pushed
the
feature/socketUtransport
branch
from
00b4399
to
838261d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an implementation for L1 transport on a TCP socket to and from a standalone python script using Dispatcher. This was validated using a standalone C++ program exercising publishing and seeing corresponding subscription callbacks.
The heart of the implementation is a single socket connected to the dispatcher, and an unordered_map whose keys are a required UUri and an optional filtering UUri, and whose values shared pointers pointing to a list of listeners for that uuri combination. The test code used to verify this is not a part of this PR.