GitHub Actions, build on push and pr on all OS #1484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My primary purpose was to make sure build still worked with the updated LSP4E/LSP4J combination as there were some breaking changes in LSP4J's latest release. Since there were no github actions for "push" I thought I would create and contribute them. |
|
Looks like more to do here - and since the Jenkins build passed (except a test failure) I am abandoning this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if there was a reason that PRs weren't being built on GHA with all platforms, so I provide this updated builder.
There is a warning (presumably preexisting and not affecting JIPP):
Warning: Using JavaSE-21 to fulfill requested profile of JavaSE-17. This might lead to faulty dependency resolution, consider defining a suitable JDK in the toolchains.xml.