Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downsampling_by_keyexpr_test investigation #1172

Draft
wants to merge 12 commits into
base: dev/1.0.0
Choose a base branch
from

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Jun 19, 2024

No description provided.

@milyin milyin changed the title experiment, if any packet is received downsampling_by_keyexpr_test investigation Jun 19, 2024
@Mallets
Copy link
Member

Mallets commented Jun 27, 2024

I manage to reproduce the test failure quite consistently while doing code coverage with:

cargo llvm-cov --test interceptors

Output:

running 3 tests
test downsampling_config_error_wrong_strategy - should panic ... ok
test downsampling_by_keyexpr ... FAILED
test downsampling_by_interface ... ok

failures:

---- downsampling_by_keyexpr stdout ----
thread 'downsampling_by_keyexpr' panicked at zenoh/tests/interceptors.rs:132:17:
The test failed on the ke`test/downsamples_by_keyexp/20hz` at the rate of 0

Sometimes I also get:

running 3 tests
test downsampling_config_error_wrong_strategy - should panic ... ok
test downsampling_by_interface ... FAILED
test downsampling_by_keyexpr ... ok

failures:

---- downsampling_by_interface stdout ----
thread 'downsampling_by_interface' panicked at zenoh/tests/interceptors.rs:132:17:
The test failed on the ke`test/downsamples_by_interface/10hz` at the rate of 0


failures:
    downsampling_by_interface

test result: FAILED. 2 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 7.05s

Zenoh:

Target platform:

  • MacBook Pro
  • CPU: Apple M3 Pro
  • OS: Sonoma 14.4.1

@Mallets
Copy link
Member

Mallets commented Jun 27, 2024

Chiming in @sashacmc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants