Select links based on message Priority & Reliability #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzypixelz
added
enhancement
This was referenced Sep 5, 2024
fuzzypixelz
force-pushed
the
link-selection
branch
2 times, most recently
from
f873bc9
to
91ee110
Compare
Preliminary throughput measurements for 743c199 and db099c1 |
fuzzypixelz
force-pushed
the
link-selection
branch
from
91ee110
to
743c199
Compare
| /// 3. QoS is enabled and priority range is available but reliability is unavailable | ||
| /// 4. QoS is enabled and reliability is available but priority range is unavailable | ||
| /// 5. QoS is enabled and both priority range and reliability are available | ||
| fn to_u64(&self) -> u64 { |
There was a problem hiding this comment.
Should not this be in zenoh-codec/zenoh-protocol cartes ?
There was a problem hiding this comment.
According to @Mallets only StateAccept could have a codec implementation as it's serialized on the wire. Otherwise this function is used for creating the ZExtZ64 and ZExtUnit extensions.
Other establishment extensions also just put their codec implementations in the same file. Even if everything were to have a codec I would still keep the try_from_64/to_u64 functions because it's the same logic.
| tracing::trace!("Scheduled: {:?}", $msg); | ||
| return pl.push_network_message($msg); | ||
| }; | ||
| /// Returns the index of the best matching [`Reliability`]-[`PriorityRange`] pair. |
There was a problem hiding this comment.
The 'smaller range' rule prevents us from returning as soon as we find a matching range. Is it worth it ?
Even with this rule we could return as soon as we find a full match with a range of 1 (cannot find a smaller range later).
There was a problem hiding this comment.
Sorry to disappoint but the search isn't even short-circuiting. It searches for three kinds of matches at the same time.
You could do search for link matching Priority and Reliability and early return on a result, but if you don't find any result you need to search by Reliability only. And if you don't find any result either you pick any link.
The search uses a fold to keep track of all three kinds of matches.
Mallets
reviewed
Sep 20, 2024
Mallets
reviewed
Sep 20, 2024
Mallets
reviewed
Sep 20, 2024
Mallets
reviewed
Sep 20, 2024
| @@ -311,6 +326,10 @@ where | |||
| n_exts -= 1; | |||
| self.write(&mut *writer, (qos, n_exts != 0))?; | |||
| } | |||
| if let Some(qos_optimized) = ext_qos_optimized.as_ref() { | |||
There was a problem hiding this comment.
Same comment as above: both ext_qos and ext_qos_optimized could be sent on the network.
If ext_qos_optimized then I don't see much the need of sending as well ext_qos.
Mallets
reviewed
Sep 20, 2024
| /// | ||
| /// ## Metadata | ||
| /// | ||
| /// - **`priorities`**: a range bounded inclusively below and above (e.g. `2..=4` signifies |
There was a problem hiding this comment.
I'd use some easier format, e.g.
priorities=1-4 would mean all priorities from 1 to 4 both included.
priorities=1 would mean only priority 1.
This is more efficient in terms of network overhead compared to 2..=4 where we need 3 characters ..= to express the same meaning of -.
There was a problem hiding this comment.
I understand. Although - is a questionable choice since it looks like substraction in this context. I suggest : (what Python uses for slicing sequences).
There was a problem hiding this comment.
Well not so questionable in terms of network overhead. I'd even suggest having something like prio=1-4 to save a few bytes more during scouting and discovery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to enable users to choose the link on which a message is sent as a function of the message's Priority & Reliability.
Supersedes #1324 and #1356.