Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven Resolver 1.9.0 #323

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

mickaelistria
Copy link
Contributor

No description provided.

@mickaelistria
Copy link
Contributor Author

@akurtakov I don't remember what's the trick to get automatic CQ creation from GitHub? Is there some bot to enable or a magic request to use in comment?

@akurtakov
Copy link
Contributor

/request-license-review

@akurtakov
Copy link
Contributor

/request-license-review

This is the magic but the comment has to be created by committer for dependabot to act.

@mickaelistria
Copy link
Contributor Author

/request-license-review

@github-actions
Copy link

/request-license-review

⚠️ Failed to request review of not vetted licenses.

Workflow run (with attached summary files):
https://github.com/eclipse/lemminx-maven/actions/runs/3479833875

@akurtakov
Copy link
Contributor

@HannesWell can you help what we miss here for the request-license-review to work?

@vrubezhny
Copy link
Contributor

Just note that two (out of 5) IPTeam requests were created by dependabot:

The requests for the other three dependencies were lost somewhere... maybe there is some limit preventing the dependabot from openning "too many IPTeam requests at once"-like (similar to open-pull-requests-limit)?

@mickaelistria
Copy link
Contributor Author

Those 2 requests come from Tycho. The lemminx-maven /request-license-review didn't manage to open new requests. Should we setup some secret or permissions?

@HannesWell
Copy link
Member

Those 2 requests come from Tycho. The lemminx-maven /request-license-review didn't manage to open new requests. Should we setup some secret or permissions?

Yes you need an IPLab authentication token stored in this GH repos secret store (since the orga is quite large you probably don't want it for that).

See for example how it was done for the Platform-Releng repo:
https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/1464

The request is quite complete. The only additional step that was missing was to confirm the bot's email address as I asked in the comments.

@HannesWell
Copy link
Member

@akurtakov I don't remember what's the trick to get automatic CQ creation from GitHub? Is there some bot to enable or a magic request to use in comment?

At the very end of the license-check workflow the instructions are mentioned:
Committers can request a review by commenting '/request-license-review'

It would be indeed nicer to see that somehow in the status but I don't know how to do that.

@mickaelistria
Copy link
Contributor Author

OK, I opened request to Eclipse infra team to add secret: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/2258

@vrubezhny
Copy link
Contributor

Those 2 requests come from Tycho. The lemminx-maven /request-license-review didn't manage to open new requests.

Ah. Yes. That's true

@mickaelistria
Copy link
Contributor Author

Thanks @vrubezhny for opening the IP requests!

@mickaelistria mickaelistria merged commit 35ed4b9 into eclipse:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants