Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code Actions for Managed Dependency Version override #366

Conversation

vrubezhny
Copy link
Contributor

This PR adds Maven project validation for managed dependency version element values override/duplication
Also this adds Code Actions for the removal of the duplicating/overriding dependency version elements and according JUnit test cases

Depends on #365

@vrubezhny vrubezhny changed the title [Add Code Actions for Managed Dependency Vrsion override [Add Code Actions for Managed Dependency Version override Feb 21, 2023
@vrubezhny vrubezhny changed the title [Add Code Actions for Managed Dependency Version override Add Code Actions for Managed Dependency Version override Feb 21, 2023
@vrubezhny vrubezhny marked this pull request as draft February 21, 2023 09:47
@vrubezhny vrubezhny force-pushed the addCodeActionsForOverridingOfManagedDependency branch from 40bbb04 to a64d68e Compare February 21, 2023 21:37
This PR adds Maven project validation for managed dependency version element values override/duplication
Also this adds Code Actions for the removal of the duplicating/overriding dependency version elements and according JUnit test cases
@vrubezhny vrubezhny force-pushed the addCodeActionsForOverridingOfManagedDependency branch from a64d68e to ddf86bb Compare February 22, 2023 19:04
@vrubezhny
Copy link
Contributor Author

@mickaelistria Updated Project Validation, Code Action and JUnit test with all 3 quickfixes

@vrubezhny vrubezhny marked this pull request as ready for review February 22, 2023 19:20
Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please merge.

@vrubezhny vrubezhny merged commit 3bd4c60 into eclipse:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants