Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion should also propose other packaging types available in Bui… #386

Merged

Conversation

vrubezhny
Copy link
Contributor

…ld extensions #267

@vrubezhny vrubezhny marked this pull request as draft April 12, 2023 22:19
@mickaelistria
Copy link
Contributor

One great test you could add would be to add a pom that defines Tycho as build extension plugin and check whether the eclipse-plugin type is available in completion.
I don't think it's so interesting to list other non-native packaging types if those can be inferred dynamically.

@vrubezhny
Copy link
Contributor Author

Yes, I'm thinking on the test. Problem could be that MavenProject is only partially setup (because of org.apache.maven.project.DefaultProjectBuilder that isn't tolerant when parsing an incomplete document, thus not returning any result in case of packaging element is empty (throwing an IllegalArgumentException immediately after ModelBuildingException related to the empty packaging occurs - that's why I disabled the dependencies resolution on building the maven project).
So a better test is needed for non-native packaging types.

@vrubezhny vrubezhny force-pushed the fixAddPackagingTypeContentAssist branch from 5d7685e to ec828b0 Compare April 13, 2023 14:17
@vrubezhny
Copy link
Contributor Author

MavenCompletionParticipantTest.testPackagingyCompletion is added with the detection of eclipse-plugin packaging type defined in org.eclipse.tycho:tycho-maven-plugin:2.7.5

@vrubezhny vrubezhny marked this pull request as ready for review April 13, 2023 16:39
Copy link
Contributor

@mickaelistria mickaelistria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition!

@vrubezhny vrubezhny merged commit 959e3f4 into eclipse:master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion should also propose other packaging types available in Build extensions
2 participants