Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when comparing versions in Content Assist #435

Merged
merged 1 commit into from
Jul 7, 2023

Commits on Jul 6, 2023

  1. Fix NPE when comparing versions in Content Assist

    ```
    Jul 06, 2023 10:50:27 AM org.eclipse.lemminx.services.XMLCompletions collectInsideContent
    SEVERE: While performing ICompletionParticipant#onXMLContent for participant 'org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipant'.
    java.lang.NullPointerException: Cannot invoke "String.toLowerCase(java.util.Locale)" because "version" is null
    	at org.apache.maven.artifact.versioning.ComparableVersion.parseVersion(ComparableVersion.java:543)
    	at org.apache.maven.artifact.versioning.ComparableVersion.<init>(ComparableVersion.java:534)
    	at org.apache.maven.artifact.versioning.DefaultArtifactVersion.parseVersion(DefaultArtifactVersion.java:94)
    	at org.apache.maven.artifact.versioning.DefaultArtifactVersion.<init>(DefaultArtifactVersion.java:44)
    	at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipant$1.compare(MavenCompletionParticipant.java:364)
    	at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipant$1.compare(MavenCompletionParticipant.java:359)
    	at java.base/java.util.TimSort.countRunAndMakeAscending(TimSort.java:355)
    	at java.base/java.util.TimSort.sort(TimSort.java:220)
    	at java.base/java.util.Arrays.sort(Arrays.java:1307)
    	at java.base/java.util.stream.SortedOps$SizedRefSortingSink.end(SortedOps.java:353)
    	at java.base/java.util.stream.Sink$ChainedReference.end(Sink.java:258)
    	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:510)
    	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
    	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
    	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
    	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
    	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
    	at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipant.onXMLContent(MavenCompletionParticipant.java:367)
    	at org.eclipse.lemminx.services.XMLCompletions.collectInsideContent(XMLCompletions.java:798)
    	at org.eclipse.lemminx.services.XMLCompletions.doComplete(XMLCompletions.java:260)
    	at org.eclipse.lemminx.services.XMLLanguageService.doComplete(XMLLanguageService.java:171)
    	at org.eclipse.lemminx.services.XMLLanguageService.doComplete(XMLLanguageService.java:166)
    	at org.eclipse.lemminx.extensions.maven.participants.completion.MavenCompletionParticipantDuplicationTest.testDuplicateCompletionVersion(MavenCompletionParticipantDuplicationTest.java:83)
    ```
    vrubezhny committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4b611e8 View commit details
    Browse the repository at this point in the history