fix: DocumentInputStream does not handle surrogate pairs correctly #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebthom
force-pushed
the
docinputstream
branch
3 times, most recently
from
70598c7
to
2a657d9
Compare
rubenporras
reviewed
Aug 20, 2024
rubenporras
reviewed
Aug 20, 2024
| this(chars::charAt, chars::length, charset, bufferSize); | ||
| } | ||
|
|
||
| public CharsInputStream(final CharsSupplier chars, final IntSupplier charsLength) { |
There was a problem hiding this comment.
This method is unused, should we remove it?
rubenporras
reviewed
Aug 20, 2024
org.eclipse.lsp4e/src/org/eclipse/lsp4e/internal/DocumentInputStream.java
Show resolved
Hide resolved
rubenporras
reviewed
Aug 20, 2024
rubenporras
reviewed
Aug 20, 2024
sebthom
force-pushed
the
docinputstream
branch
2 times, most recently
from
795c624
to
de41da2
Compare
rubenporras
reviewed
Aug 20, 2024
org.eclipse.lsp4e/src/org/eclipse/lsp4e/internal/CharsInputStream.java
Outdated
Show resolved
Hide resolved
rubenporras
reviewed
Aug 20, 2024
org.eclipse.lsp4e/src/org/eclipse/lsp4e/internal/CharsInputStream.java
Outdated
Show resolved
Hide resolved
rubenporras
reviewed
Aug 20, 2024
| } | ||
|
|
||
| try { | ||
| charBuffer.clear(); |
There was a problem hiding this comment.
should we not do the charBuffer.clear rather at the end of the method in a finally block so that we do not hold data that will never be used until the next call to refill?
There was a problem hiding this comment.
the charBuffer contains a fixed size char[] array. I don't see any advantage clearing the buffer at the end. I prefer clearing the buffer just before I start refilling and using it.
|
@sebthom , I do not have more comments. |
sebthom
force-pushed
the
docinputstream
branch
from
de41da2
to
14d95d4
Compare
@rubenporras oh man, you are thorough! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current DocumentInputStream implementation which does not handle high/low surrogate character pairs.