Add marker diagnostics asynchronously #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenporras
reviewed
Mar 16, 2023
| } | ||
| }; | ||
| IWorkspace ws = resource.getWorkspace(); | ||
| ws.run(runnable, ws.getRuleFactory().markerRule(resource), IWorkspace.AVOID_UPDATE, new NullProgressMonitor()); |
There was a problem hiding this comment.
what about and ws.getRuleFactory().markerRule(resource) and IWorkspace.AVOID_UPDATE, are those not needed anymore?
mickaelistria
force-pushed
the
async-markers
branch
6 times, most recently
from
39e4895
to
112fa33
Compare
Making it synchronous can block LS streams and cause deadlocks
mickaelistria
force-pushed
the
async-markers
branch
from
112fa33
to
faca4c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making it synchronous can block LS streams and cause deadlocks