-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCK: fix several incorrectly used annotations and associated tests #562
Conversation
Signed-off-by: Michael Edgar <michael@xlate.io>
@Emily-Jiang , let me know if you see anything changing here that would be an issue for a micro-release, v3.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this and picking out the invalid parts of the TCK app.
I have a few concerns where it looks like we could be adding a test rather than fixing one which we wouldn't want to do in a micro release and a few where I'm unsure if the change is correct.
tck/src/main/java/org/eclipse/microprofile/openapi/apps/airlines/resources/ReviewResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/airlines/resources/UserResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Outdated
Show resolved
Hide resolved
tck/src/main/java/org/eclipse/microprofile/openapi/apps/petstore/resource/PetResource.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Rouse <anrouse@uk.ibm.com>
Signed-off-by: Michael Edgar <michael@xlate.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too.
Closes #322
There are several remaining issues reported by the OpenAPI validator [1] including:
/user/special
missing schemas, this is intentional to test hidden schema functionality/user
POST request body encoding includes an extensionx-encoding
flagged invalid by the parser. This appears to be a bug [2]I verified that the smallrye-open-api implementation's
main
branch passes with these modifications.[1] https://validator.swagger.io/
[2] OAI/OpenAPI-Specification#3251