Commits on Jul 17, 2024

1. Prevent VGHM from moving guards …

   In some cases the VGHM opt was moving code above a runtime guard allowing a privatized argument load to read past the end of the object bounds. This privatized temp slot was marked collectible causing the GC to assert when the loaded value was not a valid object reference. The issue the assert is reporting would not cause any runtime behaviour issues as the guard would have prevented any of the inlined code from executing and therefore the temp would never have been used, but allowing the invalid load to happen could cause a SEGV if the load offset caused an access passed the end of the heap. This fix simply disables guard motion in this opt to prevent this problem from occurring. It's likely that move HCR guards within the bounds of GC points is fine, but performance testing will be done to insure that the cost of disabling guard motion even for HCR guards has no major performance effect.

   

   klangman committed Jul 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for db1d437
   • Browse repository at this point

   Copy the full SHA

   db1d437 View commit details

   Browse the repository at this point in the history