WIP: Add compiler options needed by openXL #7447
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for supporting the project, and congratulations on your first contribution! A project committer will shortly review your contribution. In the mean time, if you haven't had a chance please skim over the contribution guidelines which all pull requests must adhere to. If the ECA pull request check fails, have a look at the instructions for signing the ECA in the legal considerations section.
If you run into any problems our community will be happy to assist you in any way we can. There are a number of recommended ways to interact with the community. We encourage you to ask questions, or drop by to say hello.
|
please provide a proper description of what you are trying to do in this PR |
ishitaR88
requested review from
babsingh,
fjeremic,
vijaysun-omr,
dsouzai,
0xdaryl and
mstoodle
as code owners
|
as for compiler-id, could you make it consistent with Z side (they are switching to OpenXL too, on Z of course)? also, Clang 17.x.x is ambiguous: that 17 refers to OpenXL17, or refers to community Clang version 17? Detecting OpenXL as XLClang ... this is ambiguous too: we are currently using both xlC and xlclang (i.e. xlC16's xlclang front-end) already. I am not sure if it eventually worked out with this ambiguity, i prefer to staying away from the ambiguity. At least, provide abundant comments for future readers to understand it. |
ishitaR88
force-pushed
the
openxl
branch
4 times, most recently
from
af90606
to
0dcc9e4
Compare
|
Commit for openXL as Xclang is redundant it's an old change that we don't need anymore so I have removed it. |
ishitaR88
force-pushed
the
openxl
branch
4 times, most recently
from
b6a07f9
to
61ddfd5
Compare
ishitaR88
force-pushed
the
openxl
branch
5 times, most recently
from
1e8f62e
to
dfa188b
Compare
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: Ishita Ray <ishita.ray@ibm.com>
This macro will specify if openXL17 clang is used. Signed-off-by: Ishita Ray <ishita.ray@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: Ishita Ray <ishita.ray@ibm.com>
ishitaR88
changed the title
No description provided.