Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssr): add emphasis style in ssr css apache/echarts#18334 #999

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Conversation

Ovilia
Copy link
Member

@Ovilia Ovilia commented Mar 14, 2023

@Ovilia Ovilia marked this pull request as ready for review March 31, 2023 07:34
@Ovilia Ovilia changed the title WIP(ssr): add emphasis style in ssr css apache/echarts#18334 feat(ssr): add emphasis style in ssr css apache/echarts#18334 Mar 31, 2023
@Ovilia Ovilia requested review from pissang and plainheart and removed request for pissang and plainheart March 31, 2023 07:38
src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
if (!el.ignore && el.__metaData) {
const empahsisStyle = el.states.emphasis
? el.states.emphasis.style
: {};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the emphasis.disabled option is not being respected. The chart still highlights the item that the emphasis state is disabled.

src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
src/svg/graphic.ts Outdated Show resolved Hide resolved
src/svg/graphic.ts Outdated Show resolved Hide resolved
src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
src/svg/Painter.ts Outdated Show resolved Hide resolved
src/svg/cssEmphasis.ts Outdated Show resolved Hide resolved
src/svg/graphic.ts Outdated Show resolved Hide resolved
@100pah 100pah self-requested a review November 6, 2023 03:56
100pah
100pah previously approved these changes Nov 6, 2023
Copy link
Contributor

@100pah 100pah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants