Branches: REPL backslash commands for branches #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 4, 2024 12:33
|
Also fixes #1275 |
quinchs
commented
Apr 12, 2024
| fn key(&self) -> &MigrationKey; | ||
| fn parent(&self) -> anyhow::Result<&str>; | ||
| fn id(&self) -> anyhow::Result<&str>; | ||
| fn statements<'a>(&'a self) -> Self::StatementsIter<'a>; | ||
| fn statements(&'a self) -> T; |
There was a problem hiding this comment.
For context of this change, see rust-lang/rust#102211 (comment) & https://edgedb.slack.com/archives/CNECHA9EW/p1712953250921689
There was a problem hiding this comment.
Ok, this is bizzare. How'd you find the linked issue?
It doesn't seem obvious that these two problems are connected.
There was a problem hiding this comment.
a lot of debugging ended up the codepath in branch commands that used that trait, and some cheeki googling
|
Adding other branch commands is simple by adding them to the |
aljazerzen
approved these changes
Apr 15, 2024
| fn key(&self) -> &MigrationKey; | ||
| fn parent(&self) -> anyhow::Result<&str>; | ||
| fn id(&self) -> anyhow::Result<&str>; | ||
| fn statements<'a>(&'a self) -> Self::StatementsIter<'a>; | ||
| fn statements(&'a self) -> T; |
There was a problem hiding this comment.
Ok, this is bizzare. How'd you find the linked issue?
It doesn't seem obvious that these two problems are connected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1263