What's New now expects fully qualified URL (#125)

edvin · Jul 17, 2018 · b4726ef · b4726ef
1 parent eae29cd
commit b4726ef
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
 ## [1.0.20-SNAPSHOT]
 
 - Include artifact classifiers when copying dependencies
+- What's New now expects fully qualified URL (https://github.com/edvin/fxlauncher/issues/125)
 
 ## [1.0.19]
 

diff --git a/README.md b/README.md
@@ -156,7 +156,7 @@ the value of `--stop-on-update-errors` will be used.
 ## Show what's new dialog.
 
 You can have FXLauncher show a whats new dialog. This dialog will
-only be shown when FXLauncher has to download new files from the server. The html content will be shown in a `WebView`. Specify `--whats-new=https://whatsnewurl/here`
+only be shown when FXLauncher has to download new files from the server. The html will be shown in a `WebView`. Specify `--whats-new=https://whatsnewurl/here`
 
 ### Applications with no default UI
 

diff --git a/src/main/java/fxlauncher/Launcher.java b/src/main/java/fxlauncher/Launcher.java
@@ -192,9 +192,9 @@ private void launchAppFromManifest(boolean showWhatsnew) throws Exception {
         });
     }
 
-    private void showWhatsNewDialog(String whatsNewPage) {
+    private void showWhatsNewDialog(String whatsNewURL) {
         WebView view = new WebView();
-        view.getEngine().load(Launcher.class.getResource(whatsNewPage).toExternalForm());
+        view.getEngine().load(whatsNewURL);
         Alert alert = new Alert(Alert.AlertType.INFORMATION);
         alert.setTitle("What's new");
         alert.setHeaderText("New in this update");