Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user id not passing in registration success event #121

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

syedsajjadkazmii
Copy link
Contributor

Description

User ID was not being passed in the registration success event so this PR makes an identify call before firing the registration success event so that the success event can have the user id.

JIRA

VAN-2018

How Has This Been Tested?

Mention any tests you've added or updated to ensure the changes work as expected.

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.21%. Comparing base (aa19c62) to head (b0d396f).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   91.23%   91.21%   -0.02%     
==========================================
  Files          91       91              
  Lines        1711     1719       +8     
  Branches      407      411       +4     
==========================================
+ Hits         1561     1568       +7     
- Misses        147      148       +1     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@abdullahwaheed abdullahwaheed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@syedsajjadkazmii syedsajjadkazmii merged commit 91c28a8 into master Jul 22, 2024
5 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-2018 branch July 22, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants