Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: both login register page viewed event fires #129

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

syedsajjadkazmii
Copy link
Contributor

Description

It was noticed that the page viewed event was fired for both login and register pages when

  • login page was opened after register page or
  • register page was opened after login page.

JIRA

VAN-2043

How Has This Been Tested?

Locally

Screenshots/sandbox (optional):

Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.

Before After

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

@syedsajjadkazmii syedsajjadkazmii self-assigned this Aug 13, 2024
@syedsajjadkazmii syedsajjadkazmii merged commit beff591 into master Aug 15, 2024
5 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the sajjad/VAN-2043 branch August 15, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants