Skip to content

Commit

Permalink
Rename corpus info file
Browse files Browse the repository at this point in the history
  • Loading branch information
tiberiuichim committed Aug 21, 2017
1 parent dc7f2d6 commit a5c107e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
3 changes: 2 additions & 1 deletion src/eea.corpus/eea/corpus/corpus.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

def save_corpus_metadata(stats, file_name, corpus_id, text_column, **kw):
cpath = corpus_base_path(file_name) # corpus_id
meta_name = "{0}_eea.json".format(corpus_id)
meta_name = "{0}_info.json".format(corpus_id)
meta_path = os.path.join(cpath, meta_name)

title = kw.pop('title')
Expand Down Expand Up @@ -107,6 +107,7 @@ def get_corpus(request, doc=None, corpus_id=None):
if not (doc and corpus_id):
doc, corpus_id = extract_corpus_id(request)

assert doc and corpus_id
corpus = load_corpus(file_name=doc, corpus_id=corpus_id)
return corpus

Expand Down
4 changes: 2 additions & 2 deletions src/eea.corpus/eea/corpus/tests/test_corpus.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_build_corpus(self, build_pipeline, corpus_base_path, tmpdir):

build_corpus(pipeline, corpus_id, file_name, text_column, **kw)

assert path.join('test_eea.json').exists()
assert path.join('test_info.json').exists()
assert path.join('test_docs.json').exists()

docs = []
Expand All @@ -39,7 +39,7 @@ def test_build_corpus(self, build_pipeline, corpus_base_path, tmpdir):
assert docs[1] == {'text': 'Second time', 'metadata': {'3': 4}}
assert len(docs) == 2

with path.join('test_eea.json').open() as f:
with path.join('test_info.json').open() as f:
meta = json.load(f)
assert meta == {
'description': 'something else',
Expand Down
15 changes: 7 additions & 8 deletions src/eea.corpus/eea/corpus/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def available_corpus(file_name):
files[base].append(spec)

for corpus, cfs in files.items():
if len(cfs) != 4:
if len(cfs) != len(('docs', 'info')):
logger.warning("Not a valid corpus: %s (%s)",
file_name, corpus)
continue
Expand All @@ -79,19 +79,19 @@ def available_corpus(file_name):
return res


def corpus_metadata_path(file_name, corpus_id):
""" Returns the <corpusid>_eea.json file path for a given doc/corpus
def corpus_info_path(file_name, corpus_id):
""" Returns the <corpusid>_info.json file path for a given doc/corpus
"""
cpath = corpus_base_path(file_name) # corpus_id
meta_name = "{0}_eea.json".format(corpus_id)
meta_name = "{0}_info.json".format(corpus_id)
meta_path = os.path.join(cpath, meta_name)
return meta_path


def load_corpus_metadata(file_name, corpus_id):
""" Returns the EEA specific metadata saved for a doc/corpus
"""
meta_path = corpus_metadata_path(file_name, corpus_id)
meta_path = corpus_info_path(file_name, corpus_id)

res = None

Expand Down Expand Up @@ -120,9 +120,8 @@ def available_documents(request):
files[base].append(spec)

for corpus, cfs in files.items():
if len(cfs) != 4:
# logger.warning("Not a valid corpus: %s (%s)", name,
# corpus)
if len(cfs) != len(('docs', 'info')):
logger.warning("Not a valid corpus: %s (%s)", name, corpus)
continue
meta = load_corpus_metadata(name, corpus)
corpuses.append((corpus, meta))
Expand Down

0 comments on commit a5c107e

Please sign in to comment.