Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Callouts] Match latest Primer styles and colors #211

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

seshrs
Copy link
Member

@seshrs seshrs commented Sep 21, 2022

Context

The current Primer Spec callout colors were inspired by GitHub's dark mode colors (and were included in the original implementation #111). However, shortly after I merged the PR, GitHub updated their dark-mode callout styles!

Initially, I wasn't a fan of the new colors — they felt a bit too "flat". However, the styles have since grown on me, and I think it's time to match GitHub's styles.

This PR updates all callout colors to match the colors from GitHub's Primer Styles for their Alert component.

I also changed the demo callouts slightly to exclude italic styles.

Validation

BeforeAfter
Light mode image image
Dark mode image image

I think the new styles are more legible, especially in dark mode.

@seshrs seshrs added the semver/minor Pull Request proposes "minor" change label Sep 21, 2022
@seshrs seshrs added this to the WN 2023 milestone Sep 21, 2022
@github-actions
Copy link
Contributor

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/211/.

(Available until Fri Oct 21 2022.)

@awdeorio
Copy link
Contributor

I think the new styles are more legible, especially in dark mode.

I agree!

@seshrs seshrs merged commit 9b7ec60 into develop Sep 23, 2022
@seshrs seshrs deleted the callout-ui branch September 23, 2022 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/minor Pull Request proposes "minor" change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants