[Enhanced code blocks] Copy button should not omit lines with no text by default #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/222/. (Available until Fri Dec 09 2022.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221.
The bug is kind-of embarrassing. When you click the "copy" button, we run a "mapping" function on each line that determines what text should be copied.
I forgot that if a line was empty, the mapping function would retun an empty string, which is "falsy" according to the
Booleantest. I really should have explicitly checked that the map function's return value is not nullish before excluding it from the copied text. 😅