Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDF] Fix tooltip styling in dark mode #231

Merged
merged 1 commit into from
Dec 23, 2022
Merged

[PDF] Fix tooltip styling in dark mode #231

merged 1 commit into from
Dec 23, 2022

Conversation

seshrs
Copy link
Member

@seshrs seshrs commented Dec 23, 2022

In #225, I was initially unsure why the tooltip was incorrectly styled. I discovered that the issue was because of conflicting styles with the "Copy" button from Enhanced Code blocks.

This PR fixes the styles to differentiate between the different tooltip positions supported by Primer CSS.

Before After
Light mode image image
Dark mode image image

@seshrs seshrs added this to the WN 2023 milestone Dec 23, 2022
@github-actions
Copy link
Contributor

The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/231/.

(Available until Sun Jan 22 2023.)

@seshrs seshrs merged commit 8c66647 into develop Dec 23, 2022
@seshrs seshrs deleted the pdf branch December 23, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant