[Plugin] April Fools Star Wars joke #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The spec from this PR is available at https://preview.sesh.rs/previews/eecs485staff/primer-spec/256/. (Available until Tue Feb 06 2024.) |
|
Looks like the popover is incorrectly styled in dark mode, this might affect the language selector too… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Following up on my stated goal in #197: I think it would be funny if students saw a different joke each year 😅
This commit adds a new way for students to view the spec: As a Star Wars opening crawl!
Validation
Visit: https://preview.sesh.rs/previews/eecs485staff/primer-spec/256/?enable_april_fools_star_wars=1
Enabling.mov
Auto-scroll.mov
Other.buttons.mov