LaTeX support via MathJax #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seshrs
added
enhancement
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that EECS 280's Project 5 uses inline images to explain Naive Bayes. However, this doesn't look great in dark mode because the images have a white background.
I found out that it's fairly easy to introduce LaTeX support in Jekyll sites. Kramdown (the MarkDown renderer that Jekyll uses) already supports converting LaTeX expressions to HTML-compatible TeX scripts. However, these TeX scripts need to be rendered on the page. This is where MathJax comes in — simply including it as a script on the page causes these TeX expressions to be rendered to "Common HTML".
Since this is an additional JS dependency that is not needed by most spec pages, I think it's better for pages to opt-in to rendering LaTeX. I've updated
USAGE_ADVANCED.mdwith instructions on how pages can be "opted-in". I also updated the Spec demo atindex.mdwith a couple of LaTeX expressions.This PR is a "patch" because there are no visual changes to sites using Primer Spec v1.2, especially since the feature is opt-in.