Patch fix bugs from field-testing #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seshrs
added
bug
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs discovered during field-testing on EECS 485 and EECS 280 specs:
The last section in the Sidebar would never be highlighted, even when the user scrolls to that section. This issue has been fixed in c1a3764.
@zpapanas noticed (in eecs485staff/lab#6) that task-lists were not styled correctly. It turns out that Primer CSS does not appear to have public styles for task-lists! 957559c adds a temporary fix.
This PR bumps the patch version number since the features do not break pages currently built with Primer Spec v1.3.0.