Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow placing the annotation element after the selected text #232

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

daliboris
Copy link
Contributor

@daliboris daliboris commented Aug 10, 2024

In the annotation view, inserted <pb> and <note> elements are placed before the selected text.

In the case of notes, however, it's common to insert them after the commented text.

I added new property position to the data passed to the function addAnnotation() that is defined in the pb-view-annotate.js web component,

The default value of the position property is around and can be changed by specifying the value after in the @class attribute of the button for the element, for example

<paper-icon-button class="annotation-action after" data-i18n="[title]annotations.note" title="Note" ...></paper-icon-button>

In the similar way, the value before in the @class attribute is used now for elements that should be placed after the selected text.

To be functional this change must be made at the same time as the change of the pb-view-annotate.js web component.

See parallel required pull request in the Web Components for TEI Publisher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant