Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: can’t use decorators if esbuild version is >= 0.18.0 #92

Open
alex-kinokon opened this issue Jun 23, 2023 · 3 comments
Open

Bug: can’t use decorators if esbuild version is >= 0.18.0 #92

alex-kinokon opened this issue Jun 23, 2023 · 3 comments

Comments

@alex-kinokon
Copy link

Same issue as egoist/rollup-plugin-esbuild#365, register should pass experimentalDecorators to esbuild. Copied from the issue:

Starting from v0.18.0 esbuild throws an error if TypeScript decorators are used in the project.

ERROR: Experimental decorators are not currently enabled
This is because esbuild now checks for experimentalDecorators: true in tsconfig (evanw/esbuild@6f2c029).
@lynxSven
Copy link

lynxSven commented Mar 8, 2024

Is there any update?
Trying to use mocha with esbuild.
My Tests fail, because I see no way to hand the experimentalDecorators:true to my tests.

the tsconfig.json includes the value experimentalDecorators:true, but the esbuild-register doesn't take this into account.

@IcaroG
Copy link

IcaroG commented Jul 2, 2024 •
edited
Loading

Would be great to have this so we don't need to fork the lib just to upgrade esbuild.

@IcaroG IcaroG mentioned this issue Jul 2, 2024
Open
@IcaroG
Copy link

IcaroG commented Jul 3, 2024

Would you accept a PR for this? @egoist

plasmicops pushed a commit to plasmicapp/plasmic that referenced this issue Jul 18, 2024
@IcaroG
fix(esbuild): update esbuild version to bundle react-aria hostless co…
ee3447d 
…mponents

Required patch in esbuild-register package because of egoist/esbuild-register#92
Issue: https://linear.app/plasmic/issue/PLA-11026/upgrade-esbuild-to-v0189-or-later

Change-Id: I7e8dfc3aa128fffbaa019e7099d120d6f9771f4d
GitOrigin-RevId: 1424c5bc78bb17286eb2cf05b11405741d75802d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alex-kinokon @lynxSven @IcaroG