Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid literally writing import.meta.url #98

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

uhyo
Copy link

@uhyo uhyo commented Nov 3, 2023

Hi, I just forked this repository and run tests locally to see the "import.meta.url support" test fail.

Some investigation showed that the litral 'import.meta.url' in node.js was somehow replaced with __import_meta_url after build.

This PR mitigates the problem by avoiding literal import.meta.url.

Copy link

codesandbox bot commented Nov 3, 2023

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@uhyo uhyo marked this pull request as ready for review November 3, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant