Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new esbuild minifier options #331

Closed
jdalton opened this issue Mar 23, 2022 · 4 comments
Closed

add new esbuild minifier options #331

jdalton opened this issue Mar 23, 2022 · 4 comments
Labels
released

Comments

@jdalton
Copy link

jdalton commented Mar 23, 2022

esbuild has a new minify option:

  • mangleProps

See evanw/esbuild#218
@panoply
Copy link

panoply commented Mar 31, 2022

Hey @jdalton, the plugin consumes the esbuild version your project is using, you can leverage the options as long as you are using an esbuild version that support it.

@panoply panoply mentioned this issue Mar 31, 2022
Closed
@jdalton
Copy link
Author

jdalton commented Mar 31, 2022

The rollup-plugin-esbuild hard codes which options are passable to esbuild:
https://github.com/egoist/rollup-plugin-esbuild/blob/dev/src/minify.ts#L36-L47

@panoply
Copy link

panoply commented Mar 31, 2022

Ouff. 🤦🏼‍♂️ I looked at the spread like an absolute knob. apologies.

@egoist egoist closed this as completed in b05c627 Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

🎉 This issue has been resolved in version 4.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @panoply