You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for your all your OS work and bringing support for esbuild to Rollup. Looking over the code the way in which types are applied could be improved. Folks tend to rely heavily on Intellisense capabilities within editors and as we see in #331 devs will assume something it not supported when an option is not made available in completions.
We only need to omit the CommonOptions that this plugin does not support. Here is a refined approach you could leverage that will extend the ESBuild types, opposed to the interface used in index.ts
Let me know if you need a PR and I try get around to it.
importtype{CommonOptions,Loader}from'esbuild';typeOmitOptions=Omit<CommonOptions,(|'sourcesContent'|'sourcemap'|'sourceRoot'|'color'|'logLevel'|'logLimit')>typeMinifyOptions=Omit<OmitOptions,(|'format'|'sourcesContent'|'globalName'|'define'|'pure'|'jsx'|'jsxFactory'|'jsxFragment')>exportinterfaceESBuildOptionsextendsOmitOptions{sourceMap?: boolean;optimizeDeps?: MarkOptional<OptimizeDepsOptions,'cwd'|'sourceMap'>/** * Use this tsconfig file instead * Disable it by setting to `false` */tsconfig?: string|false;/** * Map extension to esbuild loader * Note that each entry (the extension) needs to start with a dot */loaders?: {[ext: string]: Loader|false;};}
The text was updated successfully, but these errors were encountered:
Hey @egoist,
Thanks for your all your OS work and bringing support for esbuild to Rollup. Looking over the code the way in which types are applied could be improved. Folks tend to rely heavily on Intellisense capabilities within editors and as we see in #331 devs will assume something it not supported when an option is not made available in completions.
We only need to omit the
CommonOptions
that this plugin does not support. Here is a refined approach you could leverage that will extend the ESBuild types, opposed to the interface used in index.tsLet me know if you need a PR and I try get around to it.
The text was updated successfully, but these errors were encountered: