Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React packaging #542

Merged
merged 37 commits into from
Jul 18, 2024
Merged

React packaging #542

merged 37 commits into from
Jul 18, 2024

Conversation

dbrewster
Copy link
Collaborator

No description provided.

jahabeebs and others added 30 commits June 9, 2024 19:24
@jahabeebs
package monorepos
6535b86
@jahabeebs
packaging monorepos
91b98c2
@jahabeebs
no reference
95282f7
@jahabeebs
clean up eidolon-client
fc5ce09
@jahabeebs
cache
a630eba
@jahabeebs
more cleanup
8c43c09
@jahabeebs
fix next.js build issue, add to tsconfig, remove excess types
0a79c8d
@jahabeebs
fix eslint issues
419b491
@jahabeebs
migrate turbo
16382a1
@jahabeebs
fix more build issues, convert eidolon-ui2 to module
e546366
@jahabeebs
revert ui2 back to standard tsconfig
b53a5f7
@jahabeebs
still making whole bundle a client component
8dc78b1
@jahabeebs
fix client/server component issues
ae14e7e
@jahabeebs
test publishing
1654b1a
@jahabeebs
cleanup
0b0f620
@jahabeebs
Merge branch 'refs/heads/main' into feature/401-package-monorepos
89ca308 
# Conflicts:
#	webui/apps/eidolon-ui2/package.json
#	webui/package.json
#	webui/pnpm-lock.yaml
@jahabeebs
update lockfile
1a78c86
@LukeLalor
Merge branch 'main' into feature/401-package-monorepos
c789b94
@LukeLalor
Merge branch 'main' into feature/401-package-monorepos
aa6661a
@jahabeebs
fix lint
8b1ed50
@jahabeebs
try building components first
06b9d3e
@jahabeebs
troubleshoot tsup config not found
901e39c
@jahabeebs
fix build
f18306f
@jahabeebs
fix tests
dbf4f99
@jahabeebs
no test?
d673d5f
@jahabeebs
need eidolon client dist
a05e612
@jahabeebs
copy dist correctly
364d0e0
@jahabeebs
strict mode
8dc2459
@jahabeebs
clean up exports
be11b97
@jahabeebs
fix path
82a91b5
@dbrewster dbrewster self-assigned this Jul 17, 2024
@dbrewster
Fixed image imports for webui.
33dbf89 
Added yaml to start up the ui piece
@jahabeebs
Copy link
Member

@dbrewster I fixed the playwright test with the following changes

  1. I noticed you renamed conversational_agent to conversational-agent in certain places. However when creating a new chat we were getting a 404 so I reverted this renaming back to conversational_agent and we were able to create new chats again 2) Our playwright test was failing because I was using a locator that was relying on the ID of the div of a chatbot's chat response being a certain number, but I made that test more specific (we now select by classname) and I also made sure that we match "Hello!" exactly as the chatbot's response

As a side note it seems now when a user is logged in the chatbot starts off with a blank message and the chatbot then responds with "Hello! Are you there?" right off the bat for some reason. This was contributing to the failing tests. Not sure if we want to fix this in this PR or a separate one, but the playwright test passes regardless of whether the user is signed in now

Screenshot 2024-07-18 at 12 59 36 AM

@dbrewster dbrewster merged commit 43653a5 into main Jul 18, 2024
17 checks passed
@dbrewster dbrewster deleted the feature/401-package-monorepos branch July 18, 2024 14:38
@LukeLalor LukeLalor linked an issue Sep 9, 2024 that may be closed by this pull request
add changeset support #578
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahabeebs jahabeebs Awaiting requested review from jahabeebs

@LukeLalor LukeLalor Awaiting requested review from LukeLalor

Assignees

@dbrewster dbrewster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add changeset support
3 participants
@dbrewster @jahabeebs @LukeLalor