Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error sending metrics when server startup failed preventing error log… #758

Merged
merged 4 commits into from
Sep 12, 2024
Merged

error sending metrics when server startup failed preventing error log… #758

merged 4 commits into from
Sep 12, 2024

Conversation

LukeLalor
Copy link
Collaborator

…ging

@LukeLalor LukeLalor linked an issue Sep 11, 2024 that may be closed by this pull request
Server process terminates suddenly since 0.1.122 #754
Closed
@LukeLalor LukeLalor enabled auto-merge (squash) September 11, 2024 23:48
@flynntsang flynntsang self-requested a review September 12, 2024 00:01
flynntsang
flynntsang approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@flynntsang flynntsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LukeLalor LukeLalor merged commit 61ab625 into main Sep 12, 2024
15 checks passed
@LukeLalor LukeLalor deleted the ll/logging_issue branch September 12, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flynntsang flynntsang flynntsang approved these changes

@dbrewster dbrewster Awaiting requested review from dbrewster

@abhi-vachani abhi-vachani Awaiting requested review from abhi-vachani

Assignees
No one assigned
Labels
None yet
Projects
Eidolon Open Source
Status: 3 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server process terminates suddenly since 0.1.122
2 participants
@LukeLalor @flynntsang