Add non-ignorable error handling feature #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spomky
force-pushed
the
features/error-non-exclusion
branch
2 times, most recently
from
e8bc44c
to
580f2f5
Compare
mremi
reviewed
Aug 13, 2024
Spomky
force-pushed
the
features/error-non-exclusion
branch
from
580f2f5
to
9a490f2
Compare
Yes, sure. What is the next version? Should be v2.1.0 right? |
Spomky
force-pushed
the
features/error-non-exclusion
branch
from
9a490f2
to
b66491b
Compare
yes perfect |
|
@Spomky the CI is failing, could you please check it? |
Spomky
force-pushed
the
features/error-non-exclusion
branch
from
b66491b
to
0641be9
Compare
|
Looks good on my side. I missed to verify the error implements all expected interfaces |
Extend the `BannedNodesRule` and `BannedUseTestRule` classes to support non-ignorable error handling. Introduced the `BannedNodesErrorBuilder` class to streamline error message construction and updated the configuration and tests accordingly.
Spomky
force-pushed
the
features/error-non-exclusion
branch
from
0641be9
to
c3d6975
Compare
mremi
approved these changes
Aug 14, 2024
|
🎉. I am happy to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal for #65.
Instead of returning a list of strings, the extension now returns a RuleError object built using the RuleErrorBuilder.
Note that I am not familiar with PHPStan extension development and this PR is a very first attempt to solve the issue I created.
Please note that this PR also sets identifiers to the errors. They are namely:
bannedcode.functionbannedcode.expressionbannedcode.testLet me know if these IDs are suitable or if you prefer to define others.