Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module/apmgorm: data race in callback #229

Closed
axw opened this issue Sep 20, 2018 · 0 comments
Closed

module/apmgorm: data race in callback #229

axw opened this issue Sep 20, 2018 · 0 comments

Comments

@axw
Copy link
Member

axw commented Sep 20, 2018

"go test -race" shows a data race in github.com/elastic/apm-agent-go/module/apmgorm_test.TestCaptureErrors
axw added a commit to axw/apm-agent-go that referenced this issue Sep 20, 2018
@axw
module/apmgorm: fix premature Span.End()
47e183b 
The Span.End() call should come after the calls
to CaptureError, which will refer to the span.

Fixes elastic#229
@axw axw mentioned this issue Sep 20, 2018
Merged
axw added a commit to axw/apm-agent-go that referenced this issue Sep 20, 2018
@axw
module/apmgorm: fix premature Span.End()
035f171 
The Span.End() call should come after the calls
to CaptureError, which will refer to the span.

Fixes elastic#229
@axw axw closed this as completed in #230 Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axw @alvarolobato