Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module/apmsql: don't report "bad connection" errors #345

Closed
axw opened this issue Dec 5, 2018 · 1 comment
Closed

module/apmsql: don't report "bad connection" errors #345

axw opened this issue Dec 5, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@axw
Copy link
Member

axw commented Dec 5, 2018 •
edited
Loading

We are reporting "bad connection" errors from module/apmsql. We should ignore driver.ErrBadConn; this is used by database/sql to identify pooled connections that should be discarded.
@axw axw added bug Something isn't working [zube]: In Progress labels Dec 5, 2018
@axw axw changed the title module/apmsql: don't report "bad connection" or "no rows in result set" errors module/apmsql: don't report "bad connection" errors Dec 5, 2018
@axw
Copy link
Member Author

axw commented Dec 5, 2018

Re earlier description including "no rows" errors: I forgot that these are deferred to Scan, and are not returned by the driver's Query methods. So, nothing to do there.

@axw axw mentioned this issue Dec 5, 2018
Merged
@axw axw closed this as completed in #346 Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axw @alvarolobato