Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmsql: don't report driver.ErrBadConn #346

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

axw
Copy link
Member

@axw axw commented Dec 5, 2018

database/sql drivers may return driver.ErrBadConn
to indicate that the connection is bad, and should
not be reused. We should not report these errors,
as they are expected by database/sql, and used for
connection pooling/reuse.

Closes #345

database/sql drivers may return driver.ErrBadConn
to indicate that the connection is bad, and should
not be reused. We should not report these errors,
as they are expected by database/sql, and used for
connection pooling/reuse.
@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #346 into master will increase coverage by 3.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   80.14%   83.61%   +3.47%     
==========================================
  Files          98       98              
  Lines        6008     6012       +4     
==========================================
+ Hits         4815     5027     +212     
+ Misses        923      921       -2     
+ Partials      270       64     -206
Impacted Files Coverage Δ
module/apmsql/conn.go 65.3% <100%> (+6.35%) ⬆️
modelwriter.go 94.16% <0%> (+0.83%) ⬆️
internal/radix/radix.go 39.92% <0%> (+0.92%) ⬆️
utils.go 80.68% <0%> (+1.13%) ⬆️
internal/sqlscanner/scanner.go 96.82% <0%> (+1.58%) ⬆️
metrics.go 91.66% <0%> (+1.66%) ⬆️
error.go 76.36% <0%> (+1.81%) ⬆️
context.go 94.05% <0%> (+1.98%) ⬆️
internal/apmhttputil/url.go 97.87% <0%> (+2.12%) ⬆️
module/apmsql/stmt.go 63.82% <0%> (+2.12%) ⬆️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949be0f...dd2a172. Read the comment docs.

@axw axw merged commit 23e55a8 into elastic:master Dec 5, 2018
@axw axw deleted the apmsql-errbadconn branch December 5, 2018 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants