Stop pooling top-level objects #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
force-pushed
the
internal-transaction
branch
from
a9fff64
to
fa16e3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
==========================================
+ Coverage 80.82% 80.88% +0.05%
==========================================
Files 96 96
Lines 5627 5701 +74
==========================================
+ Hits 4548 4611 +63
- Misses 826 828 +2
- Partials 253 262 +9
Continue to review full report at Codecov.
|
Transaction, Span, and Error are no longer pooled. Instead, new *Data types are introduced which are pooled, and those are embedded within their related top-level object types. We add a read-write mutex to the Transaction and Span types to guard access to those such that a concurrent StartSpan and Transaction.End will not panic. This change introduces an additional allocation for each of StartTransaction, StartSpan, and NewError. The time overhead (measured in nanoseconds) is not enough to warrant living with the lack of safety. It is now safe to call End() multiple times, and to call StartSpan with an ended transaction or parent span. When StartSpan is called with an ended transaction, a dropped span will be created.
axw
force-pushed
the
internal-transaction
branch
from
fa16e3b
to
0545041
Compare
|
benchstat, with 10 runs of master & this branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction, Span, and Error are no longer pooled.
Instead, new *Data types are introduced which are
pooled, and those are embedded within their related
top-level object types. We add a read-write mutex
to the Transaction and Span types to guard access
to those such that a concurrent StartSpan and
Transaction.End will not panic.
This change introduces an additional allocation for
each of StartTransaction, StartSpan, and NewError.
The time overhead (measured in nanoseconds) is not
enough to warrant living with the lack of safety.
It is now safe to call End() multiple times, and
to call StartSpan with an ended transaction or parent
span. When StartSpan is called with an ended
transaction, a dropped span will be created.
Closes #317