Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker container ID to system metadata #330

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

axw
Copy link
Member

@axw axw commented Nov 26, 2018

Update the "system" metadata with the container ID, if we detect one. Currently we only support doing this from within Docker containers.

Closes #328

@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #330 into master will decrease coverage by 3.47%.
The diff coverage is 67.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
- Coverage    84.5%   81.02%   -3.48%     
==========================================
  Files          96       98       +2     
  Lines        5802     5856      +54     
==========================================
- Hits         4903     4745     -158     
- Misses        830      840      +10     
- Partials       69      271     +202
Impacted Files Coverage Δ
internal/apmhostutil/container.go 100% <100%> (ø)
utils.go 96.77% <100%> (-1.54%) ⬇️
internal/apmhostutil/docker_linux.go 62.5% <62.5%> (ø)
model/marshal_fastjson.go 72.74% <64.7%> (-9.64%) ⬇️
internal/sqlscanner/token.go 60% <0%> (-20%) ⬇️
utils_linux.go 77.77% <0%> (-11.12%) ⬇️
sampler.go 81.81% <0%> (-9.1%) ⬇️
module/apmsql/utils.go 18.18% <0%> (-9.1%) ⬇️
internal/ringbuffer/buffer.go 81.03% <0%> (-8.63%) ⬇️
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95c23ee...c4750aa. Read the comment docs.

@axw axw merged commit b850757 into elastic:master Nov 26, 2018
@axw axw deleted the docker-container-id branch November 26, 2018 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants