Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmhttp: add status code to client spans #388

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

axw
Copy link
Member

@axw axw commented Dec 12, 2018

Also, sync latest schema.

@codecov-io
Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #388 into master will decrease coverage by 0.33%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   84.29%   83.96%   -0.34%     
==========================================
  Files         102      102              
  Lines        6253     6136     -117     
==========================================
- Hits         5271     5152     -119     
- Misses        903      913      +10     
+ Partials       79       71       -8
Impacted Files Coverage Δ
spancontext.go 100% <100%> (ø) ⬆️
model/marshal.go 81.98% <100%> (-4.59%) ⬇️
module/apmhttp/client.go 93.65% <100%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a71d9...6f29c2b. Read the comment docs.

@axw axw merged commit d98ebfb into elastic:master Dec 12, 2018
@axw axw deleted the update-schema branch December 12, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants